Enable scatter fusion with index operand. #19198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaheshRavishankar
force-pushed
the
enable_scatter_fusion
branch
from
2f8a211 to
0b126f1
Compare
MaheshRavishankar
changed the title
This drops a pessimistic check during analysis of the indexing maps of the fused `OpOperand` in the producer and consumer that was preventing fusion of the scatter operation with its index operand producer. Signed-off-by: MaheshRavishankar <mahesh.ravishankar@gmail.com>
MaheshRavishankar
force-pushed
the
enable_scatter_fusion
branch
from
0b126f1 to
6bc38ab
Compare
|
This drops number of LLaMa dispatch invocations from 714 -> 650. |
benvanik
approved these changes
Dec 18, 2024
MaheshRavishankar
added a commit
to MaheshRavishankar/iree
that referenced
this pull request
Dec 20, 2024
This reverts commit 4c00a22.
MaheshRavishankar
added a commit
to MaheshRavishankar/iree
that referenced
this pull request
Dec 20, 2024
This reverts commit 4c00a22. Signed-off-by: MaheshRavishankar <mravisha@amd.com>
MaheshRavishankar
added a commit
that referenced
this pull request
Dec 20, 2024
IanWood1
added a commit
to IanWood1/iree
that referenced
this pull request
Jan 22, 2025
…9198)" (iree-org#19535)" This reverts commit 07f81f0. Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
IanWood1
added a commit
to IanWood1/iree
that referenced
this pull request
Jan 22, 2025
…9198)" (iree-org#19535)" This reverts commit 07f81f0. Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
IanWood1
added a commit
to IanWood1/iree
that referenced
this pull request
Jan 22, 2025
…9198)" (iree-org#19535)" This reverts commit 07f81f0. Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
IanWood1
added a commit
to IanWood1/iree
that referenced
this pull request
Jan 23, 2025
…9198)" (iree-org#19535)" This reverts commit 07f81f0. Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
IanWood1
added a commit
to IanWood1/iree
that referenced
this pull request
Jan 24, 2025
…9198)" (iree-org#19535)" This reverts commit 07f81f0. Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
IanWood1
added a commit
that referenced
this pull request
Jan 27, 2025
These changes enable fusion of scatter with its producers. Relands #19198 which fixes logic to allow fusing scatter with `indices` and fully enables fusion with scatter as a producer. Testing with 8b unsharded, these changes result in [fused rope + index computation](https://gist.github.com/IanWood1/5b0b0d73f0d76dabd7669b714f066b3c) as well as [fused index computation](https://gist.github.com/IanWood1/d62452d2a2940784ff6ada711483c981). In the second case, the `updates` operand was unable to fuse because work is needed to bubble reshapes through contractions (see first bullet in this issue #19752). --------- Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
ita9naiwa
pushed a commit
to ita9naiwa/iree
that referenced
this pull request
Feb 4, 2025
These changes enable fusion of scatter with its producers. Relands iree-org#19198 which fixes logic to allow fusing scatter with `indices` and fully enables fusion with scatter as a producer. Testing with 8b unsharded, these changes result in [fused rope + index computation](https://gist.github.com/IanWood1/5b0b0d73f0d76dabd7669b714f066b3c) as well as [fused index computation](https://gist.github.com/IanWood1/d62452d2a2940784ff6ada711483c981). In the second case, the `updates` operand was unable to fuse because work is needed to bubble reshapes through contractions (see first bullet in this issue iree-org#19752). --------- Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu> Signed-off-by: Hyunsung Lee <ita9naiwa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops a pessimistic check during analysis of the indexing maps of
the fused
OpOperandin the producer and consumer that was preventingfusion of the scatter operation with its index operand producer.
Signed-off-by: MaheshRavishankar mahesh.ravishankar@gmail.com