Adding iree_hal_file_from_handle factory for common file impls. #19513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvanik
force-pushed
the
users/benvanik/host-file-2
branch
from
3aa214b to
3563283
Compare
ScottTodd
approved these changes
Dec 18, 2024
This lets us hide the details from HAL implementations. Implementations are expected to snoop the file handle type to see if they can do better and otherwise fall back to the common implementations.
benvanik
force-pushed
the
users/benvanik/host-file-2
branch
from
3563283 to
1686837
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us hide the details from HAL implementations. Implementations are expected to snoop the file handle type to see if they can do better and otherwise fall back to the common implementations.