Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GlobalOpt] Add option to propagate transposes through conv #20339

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

nirvedhmeshram
Copy link
Contributor

@nirvedhmeshram nirvedhmeshram commented Mar 21, 2025

This option is off by default as propagating transposes through convs causes weight constant folding issues with other preprocessing pipelines that might want to cancel them out.

@nirvedhmeshram nirvedhmeshram requested a review from hanhanW as a code owner March 21, 2025 16:03
@nirvedhmeshram nirvedhmeshram requested review from jerryyin and MaheshRavishankar and removed request for hanhanW March 21, 2025 16:03
Signed-off-by: Nirvedh <nirvedh@gmail.com>
Copy link
Member

@jerryyin jerryyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nirvedhmeshram nirvedhmeshram merged commit 98160ad into iree-org:main Mar 21, 2025
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants