Option to deploy server as StatefulSet #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzg
reviewed
Jul 10, 2023
|
Any progress on this? Is there only the version that needs to be bumped or are there more things to do? Also I was wondering if there are reasons to choose a deployment over a statefulset, or if it would be fine to only ever use a statefulset because this would mean a lot less to maintain. |
|
Yes it looks like just the version bump and confirmation of testing enabled and disabled. |
|
I've opened a new PR #172 with the bumped version, can verify that it creates a deployment or statefulset, depending on the setting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago #84 proposed to have the Minecraft servers deployed as StatefulSets. Due to possible problems with servers becoming too 'sticky' the idea was discarded. As I want to use this chart in conjunction with the auto-scale-up of mc-router, I need to deploy as a StatefulSet.
This PR adds
workloadAsStatefulSetas a flag to deploy the servers (Java/Bedrock) as Deployment or StatefulSet. When deploying as a StatefulSet with persistence enabled, a PVC template is configured using the information that would have been used to create a single PVC in case of a Deployment.