Add support for MODRINTH_DOWNLOAD_DEPENDENCIES #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzg
reviewed
Mar 2, 2025
|
BTW there's always extraEnv for variables that the chart doesn't expose In fact, it has become quite a maintenance headache to have mapped so many variables in the first place. My comment about the non-existent variable is a case in point 😀 . |
Change optionalDependencies to downloadDependencies
|
Should be all set now! |
itzg
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once again, thank you so much for this project!
Right now, when trying to download Modrinth plugins, there's no support for MODRINTH_DOWNLOAD_DEPENDENCIES. This means that there is no way to specify to download required dependencies from Modrinth and they all must be manually specified. This PR fixes that
(Note - this is my first time modifying a helm chart, so you should probably make sure there's nothing else I missed changing. This should still provide backwards compatibility, but I don't know if you would also want to bump the version number)