cmake: Use GNUInstallDirs instead of hardcoding lib destination #102
Conversation
|
I understand the problem. Let me see if this is the suggested fix. |
|
I see https://cmake.org/pipermail/cmake/2013-July/055374.html. Do you mind opening a pull request to change https://github.com/forexample/package-example/blob/master/Foo/CMakeLists.txt? I use this project as a basis for my CMake installs and the maintainer is a CMake expert, so I'm sure that is a better venue to discuss this. |
|
@isaachier Sure, I will do it soon. |
|
@isaachier Specyfing libdir is already done in that repo: forexample/package-example@d76608b I can change the name of the variable to |
|
OK great so let me withdraw the issue I posted there and review this. |
|
Do you mind redoing the fix similar to that package to use GNUInstallDirs throughout? |
vadorovsky
force-pushed
the
cmake-libdir
branch
2 times, most recently
from
bdf9cf7 to
ba74c83
Compare
The comon practice in cmake to allow to specify the libdir is using GNUInstallDirs and the CMAKE_INSTALL_LIBDIR variable. One of the usecases is setting /usr/lib64 as the destination dir for libraries. Signed-off-by: Michal Rostecki <mrostecki@suse.com>
vadorovsky
changed the title
|
@isaachier It's done now. |
jaegertracing/jaeger-client-cpp#102 changed lib to lib64
jaegertracing/jaeger-client-cpp#102 changed lib to lib64
The comon practice in cmake to allow to specify the libdir is
using GNUInstallDirs and the CMAKE_INSTALL_LIBDIR variable.
One of the usecases is setting /usr/lib64 as the destination dir
for libraries.