Skip to content
This repository was archived by the owner on Aug 30, 2022. It is now read-only.

Update default samplingServerURL to include /sampling path #158

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ NOTE: It is not recommended to use a remote host for UDP connections.

### Updating Sampling Server URL

The default sampling collector URL is `http://127.0.0.1:5778`. Similar to UDP address above, you can use a different URL by updating the sampler configuration.
The default sampling collector URL is `http://127.0.0.1:5778/sampling`. Similar to UDP address above, you can use a different URL by updating the sampler configuration.

```yml
sampler:
Expand Down
6 changes: 6 additions & 0 deletions src/jaegertracing/ConfigTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,12 @@ TEST(Config, testDefaultSamplingProbability)
Config().sampler().param());
}

TEST(Config, testDefaultSamplingServerURL)
{
ASSERT_EQ("http://127.0.0.1:5778/sampling",
Config().sampler().samplingServerURL());
}

TEST(Config, testZeroSamplingParam)
{
{
Expand Down
2 changes: 1 addition & 1 deletion src/jaegertracing/samplers/Config.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class Config {

static constexpr auto kDefaultSamplingProbability =
static_cast<double>(0.001);
static constexpr auto kDefaultSamplingServerURL = "http://127.0.0.1:5778";
static constexpr auto kDefaultSamplingServerURL = "http://127.0.0.1:5778/sampling";
static constexpr auto kDefaultMaxOperations = 2000;

static Clock::duration defaultSamplingRefreshInterval()
Expand Down