Use thrift 0.11.0 #94
Conversation
| src/jaegertracing/thrift-gen/zipkincore_constants.cpp | ||
| src/jaegertracing/thrift-gen/zipkincore_types.cpp | ||
| src/jaegertracing/utils/ErrorUtil.cpp | ||
| src/jaegertracing/utils/HexParsing.cpp | ||
| src/jaegertracing/utils/RateLimiter.cpp | ||
| src/jaegertracing/utils/Regex.cpp |
There was a problem hiding this comment.
couldn't these list be automated? like find src -name '*cpp'
There was a problem hiding this comment.
Ya this is a huge inconvenience of CMake but the problem is config vs. build time. CMake generates a Makefile once upon configuration. If you run CMake, then add a new file, and try running make, the generated Makefile has no idea you did anything. CMake would be able to recursively search the directories, but make isn't going to do that for you. So you need to make a hard-coded list. Details here:
We do not recommend using GLOB to collect a list of source files from your source tree. If no CMakeLists.txt file changes when a source is added or removed then the generated build system cannot know when to ask CMake to regenerate.
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
==========================================
+ Coverage 89.05% 89.73% +0.67%
==========================================
Files 96 96
Lines 2321 2318 -3
==========================================
+ Hits 2067 2080 +13
+ Misses 254 238 -16
Continue to review full report at Codecov.
|
|
Anyway, this sadly does not resolve jaegertracing/jaeger-idl#35, but I can use a patchfile to maintain the changes I used to fix it. |
|
This should resolve #45. |
Signed-off-by: Isaac Hier <ihier@uber.com>
Signed-off-by: Isaac Hier <ihier@uber.com>
* Upgrade Thrift to 0.11.0 Signed-off-by: Isaac Hier <ihier@uber.com> * Update copyrights on touched files Signed-off-by: Isaac Hier <ihier@uber.com>
|
Using a patchfile is a good alternative. |
Signed-off-by: Isaac Hier isaachier@gmail.com