Add storage secrets to es-index-cleaner cronjob #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg Franklin <gregoryfranklin@rentalcars.com>
|
This change is |
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
========================================
- Coverage 96.7% 95.2% -1.5%
========================================
Files 32 35 +3
Lines 1639 1858 +219
========================================
+ Hits 1585 1769 +184
- Misses 41 75 +34
- Partials 13 14 +1
Continue to review full report at Codecov.
|
pavolloffay
reviewed
Feb 8, 2019
| envFromSource = append(envFromSource, v1.EnvFromSource{ | ||
| SecretRef: &v1.SecretEnvSource{ | ||
| LocalObjectReference: v1.LocalObjectReference{ | ||
| Name: jaeger.Spec.Storage.SecretName, |
There was a problem hiding this comment.
@jpkrohling I am a bit outdatted with represents secretName in the storage spec?
There was a problem hiding this comment.
|
@pavolloffay , @gregoryfranklin , what's the status of this PR? |
pavolloffay
approved these changes
Feb 26, 2019
|
Adding a yaml with a secret I have used. apiVersion: v1
kind: Secret
metadata:
name: database-secrets
type: Opaque
data:
ES_USERNAME: cGFzc3dvcmQK //base64
ES_PASSWORD: cGFzc3dvcmQK |
Signed-off-by: Greg Franklin <gregoryfranklin@rentalcars.com>
|
thanks @gregoryfranklin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #196
Related to jaegertracing/jaeger#1318 which has been merged and released as
jaegertracing/jaeger-es-index-cleaner:latest. We're just adding some additional environment variables so its also fine to use with older versions of the jaeger-es-index-cleaner image.