Build binaries for Linux on IBM Power pcc64le architecture #2081

redmark-redhat · 2020-02-21T19:32:12Z

Similar to #1982

Which problem is this PR solving?

Short description of the changes

Makefile

codecov · 2020-02-21T20:16:39Z

Codecov Report

❗ No coverage uploaded for pull request base (master@7d8a2d4). Click here to learn what that means.
The diff coverage is 79.56%.

@@           Coverage Diff            @@
##             master   #2081   +/-   ##
========================================
  Coverage          ?   96.3%           
========================================
  Files             ?     214           
  Lines             ?   10540           
  Branches          ?       0           
========================================
  Hits              ?   10151           
  Misses            ?     330           
  Partials          ?      59

Impacted Files	Coverage Δ
cmd/agent/app/reporter/grpc/flags.go	`100% <ø> (ø)`
cmd/agent/app/processors/thrift_processor.go	`100% <ø> (ø)`
plugin/storage/grpc/shared/grpc_server.go	`76.47% <0%> (ø)`
cmd/collector/app/server/zipkin.go	`0% <0%> (ø)`
cmd/flags/service.go	`0% <0%> (ø)`
cmd/collector/app/server/http.go	`0% <0%> (ø)`
cmd/collector/app/server/thrift.go	`0% <0%> (ø)`
cmd/flags/flags.go	`43.47% <0%> (ø)`
cmd/query/app/static_handler.go	`85.96% <100%> (ø)`
model/adjuster/clockskew.go	`100% <100%> (ø)`
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d8a2d4...097e219. Read the comment docs.

pavolloffay · 2020-02-24T10:36:27Z

Makefile

@@ -195,6 +197,8 @@ build-examples:
 	esc -pkg frontend -o examples/hotrod/services/frontend/gen_assets.go  -prefix examples/hotrod/services/frontend/web_assets examples/hotrod/services/frontend/web_assets
 ifeq ($(GOARCH), s390x)
 	$(GOBUILD) -o ./examples/hotrod/hotrod-$(GOOS)-$(GOARCH) ./examples/hotrod/main.go
+else ifeq ($(GOARCH), ppc64le)


The build command for s390x and ppc64le are looking the same. Could we merge them?

Changes made as requested.

Signed-off-by: Yuri Shkuro <ys@uber.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

* Collect data loss metrics from clients Signed-off-by: Yuri Shkuro <ys@uber.com> * Regenerate thrift Signed-off-by: Yuri Shkuro <ys@uber.com> * Prototype Signed-off-by: Yuri Shkuro <ys@uber.com> * Upgrade Jaeger client Signed-off-by: Yuri Shkuro <ys@uber.com> * Handle wrapped counters Signed-off-by: Yuri Shkuro <ys@uber.com> * Fix formatting Signed-off-by: Yuri Shkuro <ys@uber.com> * Move to new file Signed-off-by: Yuri Shkuro <ys@uber.com> * Shutdown Signed-off-by: Yuri Shkuro <ys@uber.com> * Undo unnecessary change Signed-off-by: Yuri Shkuro <ys@uber.com> * regenerate Signed-off-by: Yuri Shkuro <ys@uber.com> * Add logging Signed-off-by: Yuri Shkuro <ys@uber.com> * cleanup Signed-off-by: Yuri Shkuro <ys@uber.com> * delint Signed-off-by: Yuri Shkuro <ys@uber.com> * Add some tests Signed-off-by: Yuri Shkuro <ys@uber.com> * Clean up Signed-off-by: Yuri Shkuro <ys@uber.com> * more tests Signed-off-by: Yuri Shkuro <ys@uber.com> * More tests Signed-off-by: Yuri Shkuro <ys@uber.com> * Reduce nesting Signed-off-by: Yuri Shkuro <ys@uber.com> * ignore overflow Signed-off-by: Yuri Shkuro <ys@uber.com> * deps Signed-off-by: Yuri Shkuro <ys@uber.com> * test Signed-off-by: Yuri Shkuro <ys@uber.com> * rename Signed-off-by: Yuri Shkuro <ys@uber.com> * comments Signed-off-by: Yuri Shkuro <ys@uber.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

* Pin grpc to 1.25.1 Signed-off-by: Yuri Shkuro <ys@uber.com> * Ignore lint errors Signed-off-by: Yuri Shkuro <ys@uber.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

* Added tracegen container image Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Added config from env for tracegen Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

* Allow raw port numbers for UDP servers Signed-off-by: Yuri Shkuro <ys@uber.com> * Better logic Signed-off-by: Yuri Shkuro <ys@uber.com> * fix tests Signed-off-by: Yuri Shkuro <ys@uber.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

…#2028) * [agent] Do not increment data loss counters on the first client batch Signed-off-by: Yuri Shkuro <ys@uber.com> * simplify tests; Signed-off-by: Yuri Shkuro <ys@uber.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Signed-off-by: Yuri Shkuro <ys@uber.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

* Introduces the new flag: collector.queue-size-memory * When the flag is set, the span processor starts a new background process to recalculate the queue capacity at regular intervals. * The span processor now keeps track of the number of spans it has seen, as well as the total bytes it processed. That information allows to derive the average spans size that the collector has processed. Along with the memory to allocate, we can come up with the ideal queue size. * New metrics: jaeger_collector_queue_capacity and jaeger_collector_spans_bytes. This commit shouldn't cause performance degradation for instances not using the new options, except for a small memory overhead due to the new span tracker (quantity/size) and the new metrics. Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Signed-off-by: Prithvi Raj <p.r@uber.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Similar to #1982 Signed-off-by: Ron Edmark <redmark@us.ibm.com>

* Standarize TLS configuration Signed-off-by: Jonah Back <jonah_back@intuit.com> * Add check for deprecated tls verify-host flag Signed-off-by: Jonah Back <jonah@jonahback.com> * fix #nosec line placement Signed-off-by: Jonah Back <jonah@jonahback.com> * Add updated lock file Signed-off-by: Jonah Back <jonah@jonahback.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Signed-off-by: Joe Elliott <number101010@gmail.com> Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Although it is spelling mistakes, it might make an affects while reading. Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Signed-off-by: Albert Chung <alchung@us.ibm.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Time adjustment is confusing to many people, as you can see in #961. This change adds a warning if we do any time adjustments, so that it's at least clear that adjustments happened. Signed-off-by: Ivan Babrou <github@ivan.computer> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

* Added new FlagList type and used it in jaeger-query Signed-off-by: Joe Elliott <number101010@gmail.com> * Added tests to confirm FlagList will be treated as stringSlice by viper Signed-off-by: Joe Elliott <number101010@gmail.com> * Added additionalheaders logic. Added tests Signed-off-by: Joe Elliott <number101010@gmail.com> * Changed http handler to take a header struct Signed-off-by: Joe Elliott <number101010@gmail.com> * Updated help text on param Signed-off-by: Joe Elliott <number101010@gmail.com> * FlagList => StringSlice Signed-off-by: Joe Elliott <number101010@gmail.com> * Additional tests to further specify string slice behavior Signed-off-by: Joe Elliott <number101010@gmail.com> * Added header parsing method and tests Signed-off-by: Joe Elliott <number101010@gmail.com> * Added support for commas in params Signed-off-by: Joe Elliott <number101010@gmail.com> * Updated flags to use expected format Signed-off-by: Joe Elliott <number101010@gmail.com> * Moved stringSliceAsHeader() to flags Signed-off-by: Joe Elliott <number101010@gmail.com> * Added test for empty string slice Signed-off-by: Joe Elliott <number101010@gmail.com> * Moved additional headers to server handler Signed-off-by: Joe Elliott <number101010@gmail.com> * Added handler and tests Signed-off-by: Joe Elliott <number101010@gmail.com> * removed unnecessary whitespace Signed-off-by: Joe Elliott <number101010@gmail.com> * checked out http_handler_test to master Signed-off-by: Joe Elliott <number101010@gmail.com> * checked out http_handler to master Signed-off-by: Joe Elliott <number101010@gmail.com> * Update cmd/query/app/additional_headers_test.go Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Joe Elliott <number101010@gmail.com> * Update cmd/query/app/flags_test.go Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Joe Elliott <number101010@gmail.com> * Update cmd/query/app/flags_test.go Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Joe Elliott <number101010@gmail.com> * Made stringSliceAsHeader return err Signed-off-by: Joe Elliott <number101010@gmail.com> * Added test for bad header params Signed-off-by: Joe Elliott <number101010@gmail.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

@yurishkuro

* Added -trimpath option to go build Fixes #2063 Signed-off-by: Pablo Caderno <kaderno@gmail.com> Signed-off-by: kaderno <kaderno@gmail.com> * Added trimpath option to go build Defined variable per suggestion of @yurishkuro Signed-off-by: kaderno <kaderno@gmail.com> * Updated last go build command Signed-off-by: Pablo Caderno <kaderno@gmail.com> Signed-off-by: kaderno <kaderno@gmail.com> * Changed variable order Signed-off-by: kaderno <kaderno@gmail.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

* Clarify that "kafka" is not a real storage backend Signed-off-by: Yuri Shkuro <ys@uber.com> * use quotes Signed-off-by: Yuri Shkuro <ys@uber.com> * update Signed-off-by: Yuri Shkuro <ys@uber.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Signed-off-by: u5surf <u5.horie@gmail.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Signed-off-by: Yuri Shkuro <ys@uber.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

* Revert "Revert latest gRPC changes to allow more flexibility in versions (#2018)" This reverts commit f605a34. Signed-off-by: Yuri Shkuro <ys@uber.com> * bump Signed-off-by: Yuri Shkuro <ys@uber.com> * bump Signed-off-by: Yuri Shkuro <ys@uber.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Signed-off-by: Kevin Earls <kearls@redhat.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Signed-off-by: Ron Edmark <redmark@us.ibm.com>

ifeq ($(GOARCH),$(filter $(GOARCH), s390x ppc64le)) Signed-off-by: Ron Edmark <redmark@us.ibm.com>

yurishkuro · 2020-02-26T18:43:18Z

your branch seems messed up, I don't think you meant to update 150 files.

redmark-redhat · 2020-02-26T18:46:43Z

Yes, I was attempting to process the DCO correction and the push went bad. Lets trash this branch and I'll start over.

redmark-redhat requested a review from a team as a code owner February 21, 2020 19:32

redmark-redhat requested a review from jpkrohling February 21, 2020 19:32

yurishkuro approved these changes Feb 21, 2020

View reviewed changes

Makefile Outdated Show resolved Hide resolved

pavolloffay reviewed Feb 24, 2020

View reviewed changes

Yuri Shkuro and others added 25 commits February 26, 2020 13:15

Clean-up staging dirs

b92f783

Signed-off-by: Yuri Shkuro <ys@uber.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Revert latest gRPC changes to allow more flexibility in versions (#2018)

d136301

* Pin grpc to 1.25.1 Signed-off-by: Yuri Shkuro <ys@uber.com> * Ignore lint errors Signed-off-by: Yuri Shkuro <ys@uber.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Publish tracegen binaries (#2022)

b3fe022

* Added tracegen container image Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Added config from env for tracegen Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Allow raw port numbers for UDP servers (#2025)

fb4c70f

* Allow raw port numbers for UDP servers Signed-off-by: Yuri Shkuro <ys@uber.com> * Better logic Signed-off-by: Yuri Shkuro <ys@uber.com> * fix tests Signed-off-by: Yuri Shkuro <ys@uber.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Count received batches from conforming clients (#2030)

b2af2b9

Signed-off-by: Yuri Shkuro <ys@uber.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Update codeowners to jaeger-maintainers team (#2034)

c609e8f

Signed-off-by: Prithvi Raj <p.r@uber.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Build binaries for Linux on IBM Power pcc64le architecture

c4b3b85

Similar to #1982 Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Supress the warn on queue-size-memory not being set (#2043)

a6a208b

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Increment size before putting in the queue (#2044)

f02d390

Signed-off-by: Joe Elliott <number101010@gmail.com> Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Fix some typo in comment (#2050)

c19d814

Although it is spelling mistakes, it might make an affects while reading. Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Add CLI flags for Kafka batching params (#2047)

5d6f6e9

Signed-off-by: Albert Chung <alchung@us.ibm.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Use memory size flag to activate dyn queue size feature (#2059)

3a500d5

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Refactor collector mains (#2060)

e6039b7

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Replace github.com/pkg/errors with native libraries (#2070)

ff34926

Signed-off-by: u5surf <u5.horie@gmail.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Update dependencies, pin grpc<1.27 (#2072)

f8d3306

Signed-off-by: Yuri Shkuro <ys@uber.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Remove pkg/errors from dependencies (#2073)

c2491c8

Signed-off-by: Yuri Shkuro <ys@uber.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

kevinearls and others added 3 commits February 26, 2020 13:31

Add service as a command line option (#2080)

25f17ed

Signed-off-by: Kevin Earls <kearls@redhat.com> Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Changed spacing

7eb8e16

Signed-off-by: Ron Edmark <redmark@us.ibm.com>

Code review changes to merge s390x and ppc64le

097e219

ifeq ($(GOARCH),$(filter $(GOARCH), s390x ppc64le)) Signed-off-by: Ron Edmark <redmark@us.ibm.com>

redmark-redhat closed this Feb 26, 2020

redmark-redhat deleted the ppc64le-support branch February 26, 2020 18:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build binaries for Linux on IBM Power pcc64le architecture #2081

Build binaries for Linux on IBM Power pcc64le architecture #2081

redmark-redhat commented Feb 21, 2020

codecov bot commented Feb 21, 2020 •

edited

Loading

pavolloffay Feb 24, 2020

redmark-redhat Feb 26, 2020

yurishkuro commented Feb 26, 2020

redmark-redhat commented Feb 26, 2020 •

edited

Loading

Build binaries for Linux on IBM Power pcc64le architecture #2081

Build binaries for Linux on IBM Power pcc64le architecture #2081

Conversation

redmark-redhat commented Feb 21, 2020

Which problem is this PR solving?

Short description of the changes

codecov bot commented Feb 21, 2020 • edited Loading

Codecov Report

pavolloffay Feb 24, 2020

Choose a reason for hiding this comment

redmark-redhat Feb 26, 2020

Choose a reason for hiding this comment

yurishkuro commented Feb 26, 2020

redmark-redhat commented Feb 26, 2020 • edited Loading

codecov bot commented Feb 21, 2020 •

edited

Loading

redmark-redhat commented Feb 26, 2020 •

edited

Loading