-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Closed & Outmoded]Add that support Kafka SASL/PLAIN authentication of SCRAM-SHA-256 or SCRAM-SHA-512 mechanism #2723
Closed
WalkerWang731
wants to merge
40
commits into
jaegertracing:master
from
WalkerWang731:add_kafka_mechanism
Closed
[Closed & Outmoded]Add that support Kafka SASL/PLAIN authentication of SCRAM-SHA-256 or SCRAM-SHA-512 mechanism #2723
WalkerWang731
wants to merge
40
commits into
jaegertracing:master
from
WalkerWang731:add_kafka_mechanism
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Signed-off-by: luhualin <luhualin@bilibili.com> Co-authored-by: luhualin <luhualin@bilibili.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
* Fix flaky tbuffered server test Signed-off-by: Pavel Kositsyn <kositsyn.pa@phystech.edu> * Apply suggestions from code review - more readable comments Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Pavel Kositsyn <kositsyn.pa@phystech.edu> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
* Add github action for jaeger integration tests Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Create separate workflow for each integration test Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Feedbacks changes Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
* Add github action for jaeger all-in-one image Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Feedbacks changes Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Feedbacks changes Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Feedbacks changes Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Feedbacks changes Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Feedbacks changes Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Make steps self-explantory Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Fix git tags issue Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Fix ES integration test Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
* Fix docker login issue with all-in-one build Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Fix docker login issue with all-in-one build Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
accept suggestions Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
accept suggestions Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
…nnectMetrics{} Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
…nnectMetrics{} Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Signed-off-by: walker.wangxy <walker.wangxy@walkerwangxydeMacBook-Pro.local>
Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
merge from jaegertracing/jaeger master
… SCRAM-SHA-512 mechanism Signed-off-by: WalkerWang731 <walker.wangxy@walkerwangxydeMacBook-Pro.local>
… SCRAM-SHA-512 mechanism Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
…1/jaeger into add_kafka_mechanism Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
pkg/kafka/auth/plaintext.go
,pkg/kafka/auth/options.go
andpkg/kafka/auth/config.go
, and not add any new file.mechanism
(reference from Kafka parameter name rules )plaintext
better thanscarm
, because these are both belong toSASL
, in the future, it can change tosasl
if needed. Actually, usingplaintext
is ok, it will not be confusing, because it name isSASL_PLAINTEXT
that from Kafka official security protocol parameter namemechanism
, I followed Kafka name rules (SCRAM-SHA-256
,SCRAM-SHA-512
,PLAIN
)plaintext
mechanism, and add to default. If users do not specify the mechanism, it not affect continued use. if users use the mechanism then just only add--kafka.ROLE.plaintext.mechanism
parameter then can use it.Changelog
Add that support Kafka SASL/PLAIN authentication of SCRAM-SHA-256 or SCRAM-SHA-512 mechanism
Parameter config of collector (
SPAN_STORAGE_TYPE=kafka
)Parameter config of ingester