Add GOVERNANCE.md #530
Merged
Add GOVERNANCE.md #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
requested review from
jpkrohling,
caniszczyk,
objectiser,
black-adder,
vprithvi and
pavolloffay
ghost
assigned 
Signed-off-by: Yuri Shkuro <ys@uber.com>
yurishkuro
force-pushed
the
governance
branch
from
3c6725b to
8187590
Compare
black-adder
approved these changes
Nov 12, 2017
objectiser
approved these changes
Nov 12, 2017
GOVERNANCE.md
Outdated
| @@ -0,0 +1,53 @@ | |||
| # Jaeger Governance | |||
|
|
|||
| This document defines project governance for the Jaeger project. | |||
There was a problem hiding this comment.
nit: could remove the first 'project'.
GOVERNANCE.md
Outdated
| * understanding of how the team works (policies, processes for testing and code review, etc), | ||
| * understanding of the projects' code base and coding style. | ||
|
|
||
| A new maintainer must proposed by an existing maintainer by sending email to jaeger-maintainers@lists.cncf.io |
There was a problem hiding this comment.
"must be proposed by"
"by sending an email"
Signed-off-by: Yuri Shkuro <ys@uber.com>
caniszczyk
reviewed
Nov 13, 2017
| * understanding of how the team works (policies, processes for testing and code review, etc), | ||
| * understanding of the projects' code base and coding style. | ||
|
|
||
| A new maintainer must be proposed by an existing maintainer by sending an email to jaeger-maintainers@lists.cncf.io |
There was a problem hiding this comment.
this should be done via a public forum, whether a public mailing list or github issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #253 and #403.