Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to bypass disk storage of Credential Store #62

Closed
wants to merge 3 commits into from

Conversation

epenet
Copy link
Contributor

@epenet epenet commented May 11, 2020

When used in API mode and inside a long running service, it might be necessary to have multiple Credential Store in parallel.
In this case, the Credential Store shouldn't be storing anything on the disk, and keep everything in memory.

This PR splits the CredentialStore class into three separate classes:

  • CredentialStore => no longer writes to disk
  • FileCredentialStore => inherits CredentialStore and add storage to disk
  • DefaultCredentialStore => replaces the old "static" CredentialStore for use within the pyze client

@jamesremuscat
Copy link
Owner

The only relevant commit here is 3d65aef, correct?

@epenet
Copy link
Contributor Author

epenet commented Jun 1, 2020

Yes, you're right. The other two are linked to #61.
Without #61 merged (or an equivalent method) merged, then this one will not work...

@epenet
Copy link
Contributor Author

epenet commented Jun 2, 2020

New PR #69 created to avoid the leak from PR 61.
I will close this one.

@epenet epenet closed this Jun 2, 2020
@epenet epenet deleted the Credential-store branch June 2, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants