Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add librevna windows application icon #285

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

bryanparadis
Copy link
Contributor

@bryanparadis bryanparadis commented Feb 21, 2025

Summary:

Just got my LibreVNA the other day. Went to pin it to my task bar, had no icon and when checking it's properties the exe doesn't contain an icon. #65 added an icon for in the application and for linux distributions through a .desktop file. This PR adds an icon to the windows executable.

Icon File generation:

sudo apt install imagemagick
convert librevna.png -define icon:auto-resize=16,48,256 -compress zip librevna.ico

Before:

image
image

After:

image
image

@jankae
Copy link
Owner

jankae commented Feb 22, 2025

Thanks, I never noticed that before (but also never pinned the GUI to the task bar). When I run the GUI, it shows up with an icon but as soon as I pin it to the task bar that icon disappears.
I'll let the automatic checks run to verify everything on my end and will merge it afterwards.

@bryanparadis
Copy link
Contributor Author

Thanks, I never noticed that before (but also never pinned the GUI to the task bar). When I run the GUI, it shows up with an icon but as soon as I pin it to the task bar that icon disappears. I'll let the automatic checks run to verify everything on my end and will merge it afterwards.

Yes. It's interesting behavior. I guess windows grabs it from the running app when that app isn't pinned.

@jankae
Copy link
Owner

jankae commented Feb 22, 2025

Works exactly as intended on my machine as well, thanks again

@jankae jankae merged commit e47ca98 into jankae:master Feb 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants