-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quitcd: fix old bug and feat. for modular export for nushell #1806
Conversation
There was no need for copy paste. You can just |
Nushell aims to focus on modularity, by replacing |
You can start by reading about modules here. And you can test by downloading nushell and then opening the terminal, typing out the following commands step by step:
Then go to another directory and exit. There we go. Think of this by also enabling users to build upon this simple function. |
@N-R-K is this good to go? |
Waiting for other nushell users to test/review.
Sorry, not interested in downloading/running pre-built binaries and also not interested in compiling thousands of dependencies just to test something I have no intention to use. |
@BeyondMagic please squash to a single commit. @mmai can you please review? |
@jarun done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @BeyondMagic . Thank you for the modular export. I saw two problems with the config_home setting and the temp file removal.
6070c0f
to
d29740e
Compare
7f800ab
to
d9a903e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks better. One small nit on the wording of --selective
flag.
2767538
to
2a442ec
Compare
Fixed, had a few problems pulling from the main branch, but now the log history is fine. |
Thanks guys! |
use nnn.nu
--force
inrm
.nnn
environment variableNNN_TMPFILE
, now it only launches for the command.