Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Django's save method update_fields kwarg #336

Merged
merged 7 commits into from
Jan 7, 2022

Conversation

abdullahkady
Copy link
Contributor

Solves #243

This has been an irritating issue that I've been facing, the issue seems to describe it quite well.
Please let me know if you have any comments :)

@abdullahkady
Copy link
Contributor Author

@hramezani @Linkid can I get an update regarding this please? I cannot request a review on the PR.
Just in case if there is anything blocking from my side, or if there is a decision that this bug is not relevant.

@Linkid Linkid requested review from hramezani and Linkid January 6, 2022 15:17
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #336 (068d0ba) into master (c9fac5c) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   82.09%   82.20%   +0.10%     
==========================================
  Files          19       19              
  Lines         497      500       +3     
==========================================
+ Hits          408      411       +3     
  Misses         89       89              
Impacted Files Coverage Δ
auditlog/diff.py 87.50% <100.00%> (+0.40%) ⬆️
auditlog/receivers.py 100.00% <100.00%> (ø)
auditlog/admin.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9fac5c...068d0ba. Read the comment docs.

@hramezani
Copy link
Member

Let's wait for @Linkid pr #339 and then the CI will be green.

@Linkid Could you please take a look meanwhile?

Copy link
Contributor

@Linkid Linkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Some minor changes to do and it will be great ! Thank you.

@abdullahkady abdullahkady requested a review from Linkid January 7, 2022 10:02
Copy link
Contributor

@Linkid Linkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@hramezani hramezani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abdullahkady

@hramezani hramezani merged commit 54dc20e into jazzband:master Jan 7, 2022
aleh-rymasheuski pushed a commit to MacmillanPlatform/django-auditlog that referenced this pull request Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants