Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing microprofile-config test issues #241

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Jul 12, 2021

This PR is to update a couple of test cases relating to MicroProfile Config which were found while testing against EAP XP3 CRs.

Actually the issues are due to the endpoint class implementation which:

  • needs to be updated in order to reflect the addition of error codes to error messages in SmallRye Config implementation, see Add i18n messages and logging smallrye/smallrye-config#288
  • needs for the customized configuration instances life cycle to be fixed so that any failure in a test will not corrupt the deployment configuration status.

CI runs:

Please make sure your PR meets the following requirements:

  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is formatted, imports ordered, code compiles and tests are passing
  • Link to the passing job is provided
  • Code is self-descriptive and/or documented
  • Description of the tests scenarios is included (see Update PR template to include TPG stuff #46)

@honza-kasik
Copy link
Member

Thank you @fabiobrz ! LGTM, merging...

@honza-kasik honza-kasik merged commit 77fe67e into jboss-eap-qe:master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants