Improve namespace lookup using .debug_names parent chain #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreytan81
force-pushed
the
improve_type_namespace_lookup
branch
2 times, most recently
from
bb42917 to
3f92956
Compare
jeffreytan81
force-pushed
the
improve_namespace_lookup_review
branch
from
985ba4f to
9a020d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a continuation of llvm#108907 by using
.debug_namesparent chain faster lookup for namespaces.Implementation
Similar to llvm#108907. This PR adds a new API:
GetNamespacesWithParentsinDWARFIndexbase class. The API performs the same function asGetNamespaces()with additional filtering using parentsCompilerDeclContext. A default implementation is given inDWARFIndexclass which parses debug info and performs the matching. In theDebugNameDWARFIndexoverride, parentsCompilerDeclContextis cross checked with parent chain in.debug_namesfor much faster filtering before fallback to base implementation for final filtering.Performance Results
For the same benchmark used in llvm#108907, this PR improves: 48s => 28s