-
-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced config.groovy
with config.jelly
in GlobalQuietPeriodConfiguration
#10362
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removes existing form validation by removing clazz:"number"
without justification.
Before

After

via
jenkins/war/src/main/webapp/scripts/hudson-behavior.js
Lines 1288 to 1292 in 23f2b9e
Behaviour.specify("INPUT.number", "input-number", ++p, function (e) { | |
e.addEventListener("keypress", preventInputEe); | |
registerMinMaxValidator(e); | |
registerRegexpValidator(e, /^((-?\d+)|)$/, "Not an integer"); | |
}); |
Thanks @daniel-beck Thinking about adding this to the developer documentation, do we have a list of which general validations there are? |
Unsure if there is such a page, there is a very general/old one in https://weekly.ci.jenkins.io/design-library/validation/ that could be adapted? |
Replaced
config.groovy
withconfig.jelly
in GlobalQuietPeriodConfigurationTesting done
Ran Jenkins in debug mode and verified that saving and loading works, and also verified that the localization still works:

Proposed changelog entries
Proposed changelog category
/label internal
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist
upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).