Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First and Last days extensions added #51

Merged
merged 5 commits into from
May 28, 2022
Merged

First and Last days extensions added #51

merged 5 commits into from
May 28, 2022

Conversation

FMorschel
Copy link
Collaborator

Fixes #50.

FELIPE EDUARDO MORSCHEL added 2 commits May 23, 2022 08:08
@jogboms
Copy link
Owner

jogboms commented May 23, 2022

I approve of this @FMorschel but do you plan to add some test cases for these?

@jogboms
Copy link
Owner

jogboms commented May 23, 2022

For the formatting, you can set your ide line width for this project to 120. @FMorschel

@FMorschel
Copy link
Collaborator Author

FMorschel commented May 23, 2022

I approve of this @FMorschel but do you plan to add some test cases for these?

Tests created @jogboms

Copy link
Owner

@jogboms jogboms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm-f1affd

@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #51 (23ec82b) into master (d11e087) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   99.74%   99.76%   +0.02%     
==========================================
  Files           2        2              
  Lines         392      434      +42     
==========================================
+ Hits          391      433      +42     
  Misses          1        1              
Impacted Files Coverage Δ
lib/src/extensions.dart 98.83% <100.00%> (+0.11%) ⬆️
test/time_test.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d11e087...23ec82b. Read the comment docs.

@jogboms jogboms merged commit 6ec373d into jogboms:master May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants