-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement loading spinner, improve UX for slow internet connection #187
Conversation
I'm still working on improving UX. Currently there is a blink of spinner when the connection is fast. Very annoying. After fixing it, I think this PR is good to go, unless you find any other issues with it. |
Now this is a lot better. It's ready for review and QA. |
This is awesome! Thanks @mkalygin 🎉 |
@mkalygin was this released or it is just on master branch yet? |
Does anyone managed to get this working? I see that this was released already but I really couldn't make it work. No errors, nothing, the loader just doesn't appear. Everything else works fine... except the arrows. It is working kinda of buggy. Seems that if the next image isn't loaded the arrow doesn't work. I have to close the Lightbox and click on the images to be able to see it. What kind of information do you want me to provide? |
@igorescobar it seems that @jossmac forgot to update JS build for this and released a new version without these changes. In the meanwhile feel free to use it from my original branch: https://github.com/mkalygin/react-images. |
@igorescobar to be precise, the ready-to-use version in |
@mkalygin that explains a lot ^^ |
I published the build files for this functionality. It looks great thanks @mkalygin ! |
@neptunian thank you very much, I'm glad to help! |
@mkalygin @neptunian thank you so much guys! |
Description of changes:
For testing, I've been using Chrome's network throttler. I tested these changes in all modern browsers. Don't forget to add
react-spinners
torollup.config.js
.srcset
preloading.BounceLoader
by default.spinner
,spinnerColor
,spinnerSize
for spinner customization.Lightbox
by moving rendering code to renderers.Related issues (if any):
#93
Checks:
npm run lint
ran successfully/src
and/examples/src
are committedScreenshots: