Upgrade react-transition-group to v2 #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've run the app in your branch and for whatever reason the images are messed up when i run the demo app: |
|
Sorry, that change should have never touched master. Gonna revert. |
|
i only checked out your branch to test it before merging and that's where I noticed the issue. |
|
It's already reverted. Please feel free to merge whenever you can. |
|
Yes, let me try and let you know.
…On Wed, 18 Jul 2018 at 11:31, Sandra ***@***.***> wrote:
Getting errors after merging your PR with latest changes. Do you have time
to check on it?
[image: screen shot 2018-07-18 at 10 30 02 am]
<https://user-images.githubusercontent.com/1676003/42872778-b9caae74-8a75-11e8-8b63-500c8710e9dc.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#238 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACxVO15WKJHnHswRoQ4IXidkK0uNgEl7ks5uHwB0gaJpZM4Utbon>
.
--
Cheers,
Filipe Costa
Software Engineer
MSc. in Computer Science - UFCG
BSc. in Computer Science - UFCG
Berlin - Germany
filipescosta.com <http://www.filipescosta.com>
|
|
I actually think I just needed to update my local repo, works fine for me now. |
|
Ok.
…On Wed, 18 Jul 2018 at 11:38, Sandra ***@***.***> wrote:
I actually think I just needed to update my local repo, works fine for me
now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#238 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACxVOzuP-aTIy3v0dqAJuHoCYXswfCs8ks5uHwH5gaJpZM4Utbon>
.
--
Cheers,
Filipe Costa
Software Engineer
MSc. in Computer Science - UFCG
BSc. in Computer Science - UFCG
Berlin - Germany
filipescosta.com <http://www.filipescosta.com>
|
|
Thanks for the PR! |
|
yup, im just going over a few more changes so it can go out in one release. |
|
What’s missing? Is it something related with this pr? |
|
no, unrelated changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
react-transition-group update from v1 to v2
Related issues (if any):
Not able to build a project if using the latest version of react-transition-group.
Checks:
yarn run lintran successfully/srcand/examples/srcare committed