Fix RSS ignoring item.id #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the tests. It also replicates jpmonette#96.
Fixes jpmonette#96 with the code that KnicKnic suggested
jpmonette
approved these changes
Oct 20, 2019
decebal
pushed a commit
to decebal/feed
that referenced
this pull request
Jun 5, 2020
* Change id to a guid This improves the tests. It also replicates jpmonette#96. * Fix RSS ignoring item.id Fixes jpmonette#96 with the code that KnicKnic suggested
jpmonette
added a commit
that referenced
this pull request
Jun 6, 2020
* Sanitizing XML feeds * Adding missing things from previous commit and also support for image with more data * Fix RSS ignoring item.id (#105) * Change id to a guid This improves the tests. It also replicates #96. * Fix RSS ignoring item.id Fixes #96 with the code that KnicKnic suggested * Bump lodash from 4.17.11 to 4.17.15 (#106) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.11...4.17.15) Signed-off-by: dependabot[bot] <support@github.com> * Create FUNDING.yml * Bump handlebars from 4.1.2 to 4.5.3 (#110) Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.1.2...v4.5.3) Signed-off-by: dependabot[bot] <support@github.com> * Item category for all feed types (#109) * Item category for all feed types. * updated version * use rimraf instead of rm -rf for dev purposes. * Bump to 4.1.0 * Bump acorn from 5.7.3 to 5.7.4 (#116) Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: 🎸 add mandatory rss2 attributes on enclosure (#120) Co-authored-by: Decebal Dobrica <decebal.dobrica@tellimer.com> * fix: 🐛 atom link needs to point to self (#122) ✅ Closes: 113 Co-authored-by: Decebal Dobrica <decebal.dobrica@tellimer.com> * Update dependencies + Formatting + Add Comments (#123) * Update dependencies * Update formating * Add comments * Bump to 4.2.0 Co-authored-by: Karl Ravn <karl.ravn@schibsted.com> Co-authored-by: Joseph Dykstra <josephdykstra@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jean-Philippe Monette <jpmonette@users.noreply.github.com> Co-authored-by: mattimbrain <matti.kaivanto@m-brain.com> Co-authored-by: Jean-Philippe Monette <contact@jpmonette.net> Co-authored-by: Decebal Dobrica <decebal.dobrica@tellimer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96 with the code that @KnicKnic recommended. This keeps backward-compatibility, and also makes
item.idwork as documented.