always use Buffer.byteLength to determine length
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there is no need to check the entity type because `Buffer.byteLength` works correctly for both `String` and `Buffer` `utf8` is the default encoding when entity is a `String` this change also make the module compatible with `TypedArray` entities see: https://nodejs.org/api/buffer.html#static-method-bufferbytelengthstring-encoding
There was a problem hiding this comment.
Thanks @pirxpilot for creating this PR! :)
Currently we support Node.js super legacy versions, like Node@0.8 and this refactor might not work for that versions (ref) buffer support was added "recently".
But this change can work 💯 for the next major 👍
|
Thanks. Makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is no need to check the entity type because
Buffer.byteLengthworks correctly for bothStringandBufferutf8is the default encoding when entity is aStringthis change also make the module compatible with
TypedArrayentitiessee:
https://nodejs.org/api/buffer.html#static-method-bufferbytelengthstring-encoding