chore: remove obsolete job params and scripts #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
force-pushed
the
remove-bootstrap-series
branch
from
fd201be to
f24b239
Compare
hpidcock
approved these changes
Feb 25, 2025
jobs/ci-run/unittest/unittests.yml
Outdated
| builders: | ||
| - wait-for-cloud-init | ||
| - install-common-tools | ||
| - apt-install: | ||
| packages: gcc squashfuse | ||
| - detect-commit-go-version |
There was a problem hiding this comment.
instead of using github api, move get-s3-source-payload up to here, then install go
jobs/ci-run/unittest/unittests.yml
Outdated
| builders: | ||
| - wait-for-cloud-init | ||
| - install-common-tools | ||
| - apt-install: | ||
| packages: gcc squashfuse | ||
| - detect-commit-go-version |
wallyworld
force-pushed
the
remove-bootstrap-series
branch
2 times, most recently
from
5f12200 to
29261d4
Compare
wallyworld
force-pushed
the
remove-bootstrap-series
branch
from
29261d4 to
bd99347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ci test jobs do not need BOOTSTRAP_SERIES params. If we want to test a controller on a specific Juju version that will be in a bespoke test.
We also don't need the params bloat in passing around GOVERSION all over the place - just detect it from the commit sha where needed using the existing script and export it.
Also delete obsolete windows and centos scripts.