Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul Gradle section regarding dependency alignment #4358

Merged
merged 8 commits into from
Mar 4, 2025
Merged

Overhaul Gradle section regarding dependency alignment #4358

merged 8 commits into from
Mar 4, 2025

Conversation

marcphilipp
Copy link
Member

@marcphilipp marcphilipp commented Mar 3, 2025 •
edited
Loading

Resolves #4343.

image

@marcphilipp marcphilipp self-assigned this Mar 3, 2025
@marcphilipp marcphilipp mentioned this pull request Mar 3, 2025
Closed
sbrannen
sbrannen requested changes Mar 3, 2025
View reviewed changes
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together.

I've added a few suggestions for minor improvements and a few questions for discussion.

@marcphilipp marcphilipp requested a review from sbrannen March 3, 2025 18:07
@sbrannen
Copy link
Member

sbrannen commented Mar 4, 2025

Looks good! 👍

Thanks for making the changes.

@marcphilipp marcphilipp merged commit 0068c24 into main Mar 4, 2025
15 checks passed
@marcphilipp marcphilipp deleted the marc/4343-gradle-docs-overhaul branch March 4, 2025 10:47
marcphilipp added a commit that referenced this pull request Mar 4, 2025
@marcphilipp
Overhaul Gradle section regarding dependency alignment (#4358)
f18554e 
Resolves #4343.

---------

Co-authored-by: Sam Brannen <104798+sbrannen@users.noreply.github.com>
(cherry picked from commit 0068c24)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrannen sbrannen sbrannen approved these changes

Assignees

@marcphilipp marcphilipp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overhaul Gradle documentation in User Guide to clarify that junit-platform-launcher now needs to be declared
2 participants
@marcphilipp @sbrannen