-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4 upgrade doc, changelog for 4.0 #3557
Conversation
also needs kubespawner 7 before final, but that's ready, I think: jupyterhub/kubespawner#866 |
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
I think we should get this ldapauthenticator fix jupyterhub/ldapauthenticator#289 into a patch release that we can include in Z2JH. |
Thoughts about what to document where etc
I've thought about this, and have a model in my head where I think things should go:
For distributions like TLJH and Z2JH, with default configuration of various dependencies and ways of configuring those dependencies, what should its changelog / general upgrade docs / version specific upgrade docs mention if a dependency has a major version bump? I think at least:
We have had examples of documentations in z2jh / tljh that caused unsustainable maintenance, because they became outdated even though the dependency project documented things clearly. That makes more docs possibly worse than less. Due to that, my mental model is to opt to lean as heavily as possible on dependent project docs and avoiding repetition as much as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the following are essential pieces for this docs:
- a link to z2jh general upgrade docs
- mention z2jhs default of
singleuser.storage.static.subPath="{username}"
for users ofsingleuser.storage.static.type="static"
could need to re-configured to"{escaped_username}"
I figure its fine to retain JupyterHub and KubeSpawner headings, but I think it can be an improvement to cut out OAuthenticator and Other package upgrades headings as it otherwise overlaps with the changelog docs without fully capturing the changelogs docs either.
- add explicit discussion of static subPath - remove redundant version update references - remove OAuthenticator change references
Thanks for thinking so much about this! I think I've updated with what you suggested. |
There's a regression in LDAPauthenticator which should be fixed by jupyterhub/ldapauthenticator#294 |
No problem waiting a bit more. We can publish once that PR lands and the hub image gets its bump. |
ldapauthenticator 2.0.2 is out now, bumped in z2jh's hub image, and I updated the changelog entries in this PR to reflect some recent PRs etc. Release date updated to 2024-11-07 -- go for release tomorrow thursday? |
Great, let's do it! |
I'll merge this and publish 4.0 shortly. |
tag published, drafting announcements |
adds 3-to-4 upgrade doc, which summarizes the relevant changes in dependencies and upgrade strategies in the chart config. I could find no changes in the chart itself that really needed upgrade docs, does anyone disagree, are there any new features we want to highlight in the upgrade doc in addition to possible breakages?
To prepare for final release, this collapses beta changelog entries into a single entry for 4.0, since I don't think we should keep changelog entries for prereleases.
I think theres some redundancy in the "version upgrade table" between the changelog and the upgrade doc. I think some redundancy is fine, but I don't have a great guide in my head for what level of info belongs where.