This repository was archived by the owner on Apr 7, 2023. It is now read-only.
Improvement of favorite button re-render delay. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should render it in both places in case of favorite request failure. |
k0kubun
reviewed
Oct 2, 2016
| } else { | ||
| client.favoriteStatus(tweet.id_str, callback); | ||
| client.favoriteStatus(tweet.id_str, (()=>{})); |
There was a problem hiding this comment.
I mean that we should keepcallback in addition to updateTweet.
|
Updated |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decreases re-render delay of favorite button after clicking it.
dispatchdoes not wait for API response anymore.