This repository was archived by the owner on Apr 7, 2023. It is now read-only.
Media popup fixes #53
Merged
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed hls media not playing because the play function would only be called from the else statement, which it never enters when the media is hls.
k0kubun
reviewed
Oct 30, 2016
| @@ -55,14 +55,23 @@ function resizeMedia(media) { | |||
| } | |||
|
|
|||
| ipcRenderer.once('load-media', (event, mediaUrl, mediaType) => { | |||
| if (mediaType !== "video/mp4" && mediaType !== "application/x-mpegURL"){ | |||
| if (mediaType !== "video/mp4" && mediaType !== "application/x-mpegURL" && mediaType !== "application/dash+xml"){ | |||
There was a problem hiding this comment.
Please put a space before { like other places.
There was a problem hiding this comment.
Arhh damn it.. I totally missed that one >_>
|
Working fine. Released as v1.5.1. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twitters in addition to mp4 and hls m3u8, had a third video container I didn't know about, mpd, so that's been added now. I also noticed that the video.autoplay would never be played if the container was hls, so that's been fixed too.