fix: Add Automatic-Module-Name attribute to jar manifests for better Java 9+ JPMS compatibility #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…9+ JPMS compatibility. Affects: db-scheduler and db-scheduler-boot-starter
kagkarlsson
changed the title
|
I had to disable this again for the spring-boot-starter module due error when building. Have not had time to investigate, but I have added javadoc+sources to the CI-verification to catch it before merge. |
|
See #498 |
|
🎉 This issue has been resolved in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Automatic-Module-Name attribute to jar manifests for better Java 9+ JPMS compatibility.
Affects: db-scheduler and db-scheduler-boot-starter.
Naturally the automatic module names I have entered are suggestions - please amend if required.
Fixes
Required filename-based automodules detected: [db-scheduler-13.0.0.jar]. Please don't publish this project to a public artifact repository!Reminders
mvn spotless:applycc @kagkarlsson