fix: ManualSchedulerBuilder uses provided SchedulerListeners #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kagkarlsson hi! Any chance you could look at this? :) |
kagkarlsson
reviewed
Mar 8, 2025
| @@ -58,6 +66,7 @@ public void onExecutionStart(CurrentlyExecuting currentlyExecuting) { | |||
| }); | |||
| } | |||
|
|
|||
| @SuppressWarnings("CodeBlock2Expr") | |||
There was a problem hiding this comment.
Not sure about this... I think maybe just drop these.. (or put it on class-level at least.. )
Comment on lines
+479
to
483
|
|
||
| public SchedulerListeners getSchedulerListeners() { | ||
| return this.schedulerListeners; | ||
| } | ||
| } |
Comment on lines
+25
to
+36
| private final SchedulerListener listener = | ||
| new SchedulerListener() { | ||
|
|
||
| @Override | ||
| public void onExecutionScheduled(TaskInstanceId taskInstanceId, Instant executionTime) { | ||
| LOG.info("onExecutionScheduled()"); | ||
| } | ||
|
|
||
| @Override | ||
| public void onExecutionStart(CurrentlyExecuting currentlyExecuting) { | ||
| LOG.info("onExecutionStart()"); | ||
| } |
There was a problem hiding this comment.
I think you can use SchedulerListener.NOOP instead of defining this one..
Comment on lines
+65
to
+71
| public void register_scheduler_listener() { | ||
| LOG.info("register_scheduler_listener()"); | ||
|
|
||
| ManualScheduler scheduler = TestHelper.createManualScheduler(postgres.getDataSource()).build(); | ||
|
|
||
| assertDoesNotThrow(() -> scheduler.registerSchedulerListener(listener)); | ||
| } |
There was a problem hiding this comment.
Was the case previously that this method threw an exception?
Comment on lines
+25
to
+28
| private final SchedulerListener listener = | ||
| new SchedulerListener() { | ||
|
|
||
| @Override |
Comment on lines
+65
to
+74
| public void manual_scheduler_listener() { | ||
| LOG.info("manual_scheduler_add_listener()"); | ||
|
|
||
| ManualScheduler scheduler = | ||
| TestHelper.createManualScheduler(postgres.getDataSource()) | ||
| .addSchedulerListener(listener) | ||
| .build(); | ||
|
|
||
| assertThat(scheduler.getSchedulerListeners().getSchedulerListeners(), hasItem(listener)); | ||
| } |
There was a problem hiding this comment.
Possibly a "better" test, or at least one not requiring the method scheduler.getSchedulerListeners() is to attach a listener, run an execution, and verifying that the listener was called (NOOP will not work for that case)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief, plain english overview of your changes here
Made ManualSchedulerBuilder use provided SchedulerListeners instead of a hard coded list. Also fixed
ManualScheduler.registerSchedulerListener()throwing an unsupported operation exception.Fixes
#532
Reminders
mvn spotless:applycc @kagkarlsson