feat: expose missedHeartbeatsLimit config through Spring Boot properties (addresses #633)
#634
+26
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallind
changed the title
missedHeartbeatsLimit config through Spring Boot propertiesmissedHeartbeatsLimit config through Spring Boot properties
wallind
changed the title
missedHeartbeatsLimit config through Spring Boot propertiesmissedHeartbeatsLimit config through Spring Boot properties (addresses #633)
|
I made an educated guess how you might like tests updated for this work e7ccf82; if you'd like something different just let me know and I'm happy to adjust. |
kagkarlsson
reviewed
Mar 8, 2025
| /** | ||
| * How many heart beats can be missed before an execution is considered dead. | ||
| * | ||
| * <p>Must be greater than 4 |
There was a problem hiding this comment.
yep yep; addressed in rebased history, see 4c28c7a
kagkarlsson
approved these changes
Mar 8, 2025
*_also includes some minor grammar/spelling fixes_
wallind
force-pushed
the
633-expose-missedHeartbeatsLimit-config-through-Spring-Boot-properties
branch
from
e7ccf82 to
d07ab8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief, plain english overview of your changes here
Exposes the
missedHeartbeatsLimitconfiguration added in #432 through the Spring BootDbSchedulerProperties.Fixes
Closes #633.
Reminders
mvn spotless:applycc @kagkarlsson