Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #6227: to prevent the generation judgment from always being false #6234

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Mar 26, 2025

Cherry pick of #6227 on release-1.13.
#6227: to prevent the generation judgment from always being false
For details on the cherry pick process, see the cherry pick requests page.

`karmada-controller-manager`: Fixed the issue that the gracefulEvictionTask of ResourceBinding can not be cleared in case of schedule fails.

…gracefulEvictionTask clearance, move the generation judgment logic to the reconcile

Signed-off-by: changzhen <changzhen5@huawei.com>
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 26, 2025
@XiShanYongYe-Chang XiShanYongYe-Chang mentioned this pull request Mar 26, 2025
3 tasks
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Project coverage is 47.96%. Comparing base (9da8915) to head (152ea33).

Files with missing lines Patch % Lines
pkg/controllers/gracefuleviction/evictiontask.go 70.00% 2 Missing and 1 partial ⚠️
...acefuleviction/crb_graceful_eviction_controller.go 75.00% 2 Missing ⚠️
...racefuleviction/rb_graceful_eviction_controller.go 75.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.13    #6234      +/-   ##
================================================
- Coverage         47.98%   47.96%   -0.02%     
================================================
  Files               674      674              
  Lines             55863    55863              
================================================
- Hits              26804    26797       -7     
- Misses            27311    27315       +4     
- Partials           1748     1751       +3     
Flag Coverage Δ
unittests 47.96% <73.07%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2025
@karmada-bot karmada-bot merged commit 02e2947 into karmada-io:release-1.13 Mar 26, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants