Shareableviz extended support #1749
Merged
+1,510
−672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
* refactor router to accept new deployer inputs Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * refactor cli for shareableviz deploy Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * merge router change Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * PR comments fix Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> --------- Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
* CLI command kedro viz build added * Lint fix * lint fix * Lint fix * add mypy ignore * Missing build file added * Lint error fix * BaseDeployer class added * Unused code removed * Fix lint issue * azure deploy initial draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * added base_deployer * add deployer factory * partial working draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * Test and comments of deployers updated * test draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix lint Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove circular dependency Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix lint Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * revert back consent Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * minor updates Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * update pytests Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * add pytest for azure shareableviz Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * refactor and add timeout Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * refactor cli Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * update pytest Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * add release note Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix PR comments and flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * testing flaky c y test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * resolve conflicts Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix PR comments Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * add back cypress flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove cypress flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove duplicate pytest parameter Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove fsspec upper bound Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> --------- Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> Co-authored-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com> Co-authored-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
* CLI command kedro viz build added * Lint fix * lint fix * Lint fix * add mypy ignore * Missing build file added * Lint error fix * BaseDeployer class added * Unused code removed * Fix lint issue * azure deploy initial draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * added base_deployer * add deployer factory * partial working draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * Test and comments of deployers updated * test draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix lint Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove circular dependency Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix lint Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * revert back consent Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * initial draft Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * minor updates Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * update pytests Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * add pytest for azure shareableviz Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * refactor and add timeout Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * refactor cli Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * update pytest Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * add release note Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix PR comments and flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * testing flaky c y test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * remove flaky test Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * add pytest for gcp Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix gcp pytest coverage Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * fix lint Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * update pytest Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * revert file permission change --------- Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> Co-authored-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com> Co-authored-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>
ravi-kumar-pilla
changed the title
* shareable viz with multiple platform UI * test fix * Relative path fix for user entered url * Test updated * Test updated * UI alignment and endpoint help text added. Signed-off-by: <> * Add Kedro-Viz documentation URLs and update modal content Signed-off-by: <> * Code review suggestions added Signed-off-by: <> * Refactor form field names in ShareableUrlModal component Signed-off-by: <> * Add cursor style to input field in shareable-url-modal.js Signed-off-by: <> * Add cursor style to input field in shareable-url-modal.js Signed-off-by: <> * Variable names updated. Signed-off-by: <> * add exception handlers Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> * Disclaimer note added and shareable-url-modal component refactored by moving major jsx to other file Signed-off-by: <> * Wrapped the prop methods with useCallback Signed-off-by: <> * info text updated. Signed-off-by: <> * Test fixed Signed-off-by: <> * test fix and rearranging jsx Signed-off-by: <> * Cypress test fix Signed-off-by: <> * button text updated Signed-off-by: <> * Keeping button text as Publish for a link seetings Signed-off-by: <> --------- Signed-off-by: <> Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com> Co-authored-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
ravi-kumar-pilla
requested review from
rashidakanchwala,
NeroOkwa and
jitu5
as code owners
Signed-off-by: <>
jitu5
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a consolidated branch of all the shareableviz work in the PRs - #1739, #1740, #1708, #1711, #1718,
Development notes
Refer PRs - #1739, #1740, #1708, #1711, #1718,
QA notes
Checklist
RELEASE.mdfile