-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove code for backwards compatibility #1254
Conversation
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
67c8088
to
fe4f86a
Compare
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
3846843
to
bf33c5e
Compare
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
bf33c5e
to
42bcc4d
Compare
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much for this being a simple 1 point ticket 😬 Great job getting through it!
Just two small suggestions, not important:
- If
_ProjectPipelines.configure
is usually called withpipelines_module = None
then it might be worth giving it a default value ofNone
so those calls don't have to specifyNone
explicitly (which looks very slightly unnatural to me). - Maybe
__init__
should also callself.configure
just to reduce repetition and make it clear it's doing the same thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff! 🥇
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
I've addressed point 1, but for point 2 it seems weird to not define the class attributes in |
Signed-off-by: Merel Theisen merel.theisen@quantumblack.com
Description
We still had some code in place for backwards compatibility that should be removed in
0.18.0
.Development notes
kedro.framework.project._init_.py
there for backwards compatibility with projects that don't have thepipeline_registry.py
file.configure_project(package_name)
on session creation.Checklist
RELEASE.md
file