Improve the distinction between leaf positions and leaf values #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The non-index version of the function isn't needed anymore, except to make javascript tests easier to write. Move it to the test stub contract.
nkuba
approved these changes
Feb 24, 2020
nkuba
added a commit
that referenced
this pull request
Mar 20, 2020
Bumping up version for 0.2.0 release
0.2.0 will contain:
Improve the distinction between leaf positions and leaf values #64
Function to check if initialization period passed #66
Reduce the cost of initialization queries during group selection #67
Fully backed pool #69
Drop solidity bytes utils dependency #70
Factory for FullyBackedSortitionPool #71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is not always clear whether a
uint256value refers to a leaf, or its position inleaves. This PR renames a number of functions and variables to highlight the difference. Additionally, the function namepickWeightedLeafWithIndexis dropped andpickWeightedLeafnow has its behavior.