Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds primitives needed for BLS12-381 hash_to_curve for G1 & G2 #258

Merged
merged 64 commits into from
Feb 6, 2025
Merged

Adds primitives needed for BLS12-381 hash_to_curve for G1 & G2 #258

merged 64 commits into from
Feb 6, 2025

Conversation

petscheit
Copy link
Contributor

@petscheit petscheit commented Nov 28, 2024 •
edited
Loading

This PR adds map_to_curve, isogeny and cofactor clearing circuits for G1/G2 points. This enables the conversion of hashes to G2 points

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

@petscheit
feat: impl fp2 add, sub & inv
d4e3f2a
@petscheit
feat: add more fp2 operations
3166a17
@petscheit
feat: impl dqrt function found in ark_algebra
6841b63
@petscheit
feat: add fp2 horner eval + g2 bls12-381 isogeny params
59f9a20
@petscheit
feat: add is_non_zero
775560c
@petscheit
feat: add map_to_curve_g2 circuit logic
72961d2
@petscheit
feat: add g2 isogeny logic
4527b84
@petscheit
chore: rename
fb110a0
@petscheit
fix: update sqrt logic
933d5e0
@petscheit
feat: add ec_add for g2
2ec6558
@petscheit
feat: add isogeny g2
ccbedd2
@petscheit
fix: parity logic
500216d
@petscheit
feat: add effective cofactor clearing using addition chains
5dd505e
@petscheit
feat: add fast g2 cofactor clearing
61a36a2
@petscheit
Merge pull request #4 from petscheit/feat/cofactor
8419a65 
Feat/cofactor
@petscheit
Merge branch 'hash_to_curve' into feat/hash_to_curve
64ebdd5
@petscheit
chore: readd lost function
35842c7
@petscheit
Merge branch 'feat/hash_to_curve' of https://github.com/petscheit/garaga
b5acf6a 
 into feat/hash_to_curve
@petscheit
chore: cleanup
5fb6e38
@petscheit
Merge pull request #5 from petscheit/feat/hash_to_curve
c510ded 
Feat/hash to curve
@petscheit
chore: add missing g2 functions
96cffe3
@petscheit
feat: add sqrt selection logic
4dd3006
@petscheit
fix: faulty fp2 parity logic
aca8811
@petscheit
chore: add tests for added logic
44f701d
@petscheit
fix: python version which breaks on a macos dep
ca2fe12
@petscheit
chore: regenerate circuit
2f0e312
@petscheit
Merge pull request #6 from petscheit/hash_to_curve
1493b07 
Adds logic needed for BLS hash to curve
@petscheit
Copy link
Contributor Author

@feltroidprime bump

@feltroidprime feltroidprime force-pushed the main branch 2 times, most recently from a274d03 to 5e53010 Compare February 5, 2025 11:15
feltroidprime
feltroidprime reviewed Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@feltroidprime feltroidprime left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks now mergeable. Please apply final circuit modifications if you need.

@feltroidprime feltroidprime merged commit e313d42 into keep-starknet-strange:main Feb 6, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feltroidprime feltroidprime feltroidprime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petscheit @feltroidprime