Allow specifying the version of buildtools in bzlmod #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgrindel
reviewed
May 15, 2024
There was a problem hiding this comment.
Could we add an example that exercises the toolchains bzlmod tag? We should then ensure that the example runs with the integration tests.
hunshcn
force-pushed
the
feat/bzl-version
branch
2 times, most recently
from
23e79ac to
58245e6
Compare
|
I'm sorry that the test has failed before due to my unfamiliarity with the test and some accidents. Now it should be fine. |
|
ping @keith Although 7.3.1 has been updated, it may be meaningful in the future. Or close this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #86