Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnings #804

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Fix clippy warnings #804

merged 3 commits into from
Jun 18, 2024

Conversation

ansasaki
Copy link
Contributor

Fix some warnings raised by clippy

ansasaki added 3 commits June 18, 2024 14:16

Verified

This commit was signed with the committer’s verified signature.
lionkor Lion
Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>

Verified

This commit was signed with the committer’s verified signature.
lionkor Lion
Previously, it would be possible to enter an inifite loop when checking
for mounted directories in case of error reading a file.

This interrupts the loop in case of error.

This was raised as a clippy warning.

Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.30%. Comparing base (2f7b3ad) to head (335bc82).
Report is 32 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 61.30% <50.00%> (+3.71%) ⬆️
upstream-unit-tests 61.30% <50.00%> (+10.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
keylime-agent/src/secure_mount.rs 67.50% <100.00%> (ø)
keylime-agent/src/error.rs 15.25% <50.00%> (ø)
keylime-agent/src/revocation.rs 70.40% <0.00%> (-0.73%) ⬇️

... and 8 files with indirect coverage changes

@ansasaki ansasaki merged commit c195ef6 into keylime:master Jun 18, 2024
17 of 18 checks passed
@ansasaki ansasaki deleted the fix_clippy_warnings branch June 18, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants