Skip to content
This repository was archived by the owner on Jan 29, 2023. It is now read-only.

Setting FTP_CRED_SIZE on the fly like with FTP_BUF_SIZE #4

Closed
davekc opened this issue Sep 29, 2022 · 2 comments
Closed

Setting FTP_CRED_SIZE on the fly like with FTP_BUF_SIZE #4

davekc opened this issue Sep 29, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@davekc
Copy link

davekc commented Sep 29, 2022

FTP_CRED_SIZE is defined to 16 (limiting the credentials to 15 characters actually)

What about setting it to 17 by default or...

Being able to set it on the fly like with FTP_BUF_SIZE

#if (!defined(FTP_CRED_SIZE))
  #warning Using default FTP_CRED_SIZE = 17
  #define FTP_CRED_SIZE 17
#endif

Thanks for the library!

@davekc
Copy link
Author

davekc commented Sep 29, 2022

Or course it could be implemented differently. Like:

char user[FTP_CRED_SIZE +1]; // user name
char pass[FTP_CRED_SIZE +1]; // password

Then:

if ( strlen( _user ) > 0 && strlen( _user ) <= FTP_CRED_SIZE )
if ( strlen( _pass ) > 0 && strlen( _pass ) <= FTP_CRED_SIZE )

Just an idea ;)

Kind regards,
Dave

khoih-prog added a commit that referenced this issue Oct 8, 2022
### Releases v1.2.0

1. Add support to `WiFiNINA`, such as `Adafruit Airlift Featherwing`
2. Configurable `user_name` length to 63 and `user_password` to 127. Check [Setting FTP_CRED_SIZE on the fly like with FTP_BUF_SIZE #4](#4)
khoih-prog added a commit that referenced this issue Oct 8, 2022
### Releases v1.2.0

1. Add support to `WiFiNINA`, such as `Adafruit Airlift Featherwing`
2. Configurable `user_name` length to max 63 and `user_password` to max 127. Check [Setting FTP_CRED_SIZE on the fly like with FTP_BUF_SIZE #4](#4)
khoih-prog added a commit that referenced this issue Oct 8, 2022
### Releases v1.2.0

1. Add support to `WiFiNINA`, such as `Adafruit Airlift Featherwing`
2. Configurable `user_name` length to max 63 and `user_password` to max 127. Check [Setting FTP_CRED_SIZE on the fly like with FTP_BUF_SIZE #4](#4)
@khoih-prog
Copy link
Owner

Hi @davekc

The new FTP_Server_Teensy41 v1.2.0 has just been published. Your contribution is noted in Contributions and Thanks

Best Regards,


Releases v1.2.0

  1. Add support to WiFiNINA, such as Adafruit Airlift Featherwing
  2. Configurable user_name length to max 63 and user_password to max 127. Check Setting FTP_CRED_SIZE on the fly like with FTP_BUF_SIZE #4

@khoih-prog khoih-prog added the enhancement New feature or request label Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants