fix: loading placeholder size in user-avatar #5910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
christian14b
commented
Apr 3, 2025
•
christian14b
commented
- Fixing loading sizes
- Image infinite loading issue
roger-in-kiva
approved these changes
Apr 3, 2025
dyersituations
approved these changes
Apr 3, 2025
| onMounted(() => { | ||
| avatarsRefs.value.forEach(async el => { | ||
| const img = el.imageRef; | ||
| await waitForImageToComplete(img); |
There was a problem hiding this comment.
Is this something we can do within the avatar component? Otherwise we'll have to do this change with each use case.
There was a problem hiding this comment.
Yeah, I was working on that now, I'll open a PR soon
There was a problem hiding this comment.
dyersituations
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.