Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: optin notification avatar sizes #5913

Merged
merged 1 commit into from
Apr 4, 2025
Merged

fix: optin notification avatar sizes #5913

merged 1 commit into from
Apr 4, 2025

Conversation

christian14b
Copy link
Collaborator

Before:
image

After:
image

@christian14b christian14b requested a review from a team April 4, 2025 19:58
dyersituations
dyersituations approved these changes Apr 4, 2025
View reviewed changes
Copy link
Collaborator

@dyersituations dyersituations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christian14b have you tested all other usages of the shared component? I forget how often we've used this particular avatar.

@christian14b
Copy link
Collaborator Author

@christian14b have you tested all other usages of the shared component? I forget how often we've used this particular avatar.

Yeah, this is only in My Kiva thank page and the single version, we're good on both

@christian14b christian14b merged commit 48139c4 into main Apr 4, 2025
5 checks passed
@christian14b christian14b deleted the fix-optin-notification-avatars branch April 4, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyersituations dyersituations dyersituations approved these changes

@roger-in-kiva roger-in-kiva roger-in-kiva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christian14b @dyersituations @roger-in-kiva