feat: add variables field to the v1beta3 eventtype spec

[Ahmed-Labs]

Fixes #7729

Proposed Changes

• Add EventVariableDefinitions to EventTypeSpec
• Validate whether variables used within attribute values are defined
• Update EventType v1beta3 CRD with added variables field

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact
• Spec PR for any new API feature
• Conformance test for any change to the spec

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Ahmed-Labs / name: Ahmed Mohamed (6baa454, c6f6c9c, 7d00dad, 71b4b68)

[knative-prow]

Welcome @Ahmed-Labs! It looks like this is your first PR to knative/eventing 🎉

[knative-prow]

Hi @Ahmed-Labs. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Cali0707]

Awesome start @Ahmed-Labs, thanks for working on this!

I left a few comments, and then I think this will be good to merge

[Cali0707]

/ok-to-test

[Cali0707]

/cc @pierDipi @matzew

FYI, this is the follow up regarding eventtypes with variables

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.16%. Comparing base (cdc6144) to head (71b4b68).
Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8445      +/-   ##
==========================================
+ Coverage   64.10%   64.16%   +0.06%     
==========================================
  Files         388      388              
  Lines       23363    23405      +42     
==========================================
+ Hits        14976    15018      +42     
  Misses       7591     7591              
  Partials      796      796              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ahmed-Labs
Once this PR has been reviewed and has the lgtm label, please ask for approval from cali0707. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Cali0707]

/ok-to-test

[Cali0707]

@Ahmed-Labs can you fix the format errors?

[Cali0707]

/lgtm

/cc @matzew @pierDipi

Could one of you provide a second review on this?

[pierDipi]

We need to ensure that every EventType version can be converted to and from v1beta3, so we need to add these new fields (and type) to every other served version (v1beta2 and v1beta1), otherwise the new fields will be dropped as the objects are stored using v1beta2:

eventing/config/core/resources/eventtype.yaml

Lines 171 to 173 in 71b4b68

	- name: v1beta2
	served: true
	storage: true

Also we would need to update the validation functions for other versions too as it's done in the PR for v1beta3, so perhaps, we can extract common logic (like extract variables, etc) to a common file like ./pkg/apis/eventing/eventtype_validation_common.go

---

Once we've added the fields, types and validations to other versions, we need to update the conversion functions (for v1beta1 and v1beta2) like this one to set such new fields

https://github.com/knative/eventing/blob/71b4b68d3fd2e06d587fb05887027b3e6e15eb35/pkg/apis/eventing/v1beta1/eventtype_conversion.go

[pierDipi]

Would this be a valid and interesting case to test as well? test.{test\\{Variable}.{defined\\}Variable}

[pierDipi]

Thanks @Ahmed-Labs, I left a review