Feature/567 number encodings #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… numbers in a dl-program
Merge remote-tracking branch 'origin/main' into feature/567-number-encodings
aannleax
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Looks good overall, apart from the small issues above.
Aside from those, I would also like to see an integration test, i.e. a new test case in the nemo/resources/testcases directory, which (1) tests parsing such numbers from facts and (2) and adds to the test case arithmetic/builtin for the extension to the conversion to i64 builtin.
mmarx
reviewed
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables reading of binary (
0b), octal (0o) and hexadecimal (0x) encodings in the facts and rules of a program.The decoding of imported facts is not supported.
Encoded numbers that exceed the size of
i64are decoded intobigintand then handled as strings with iri-typexsd:integer.closes #567.