Bug/598 evaluate expressions facts #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monsterkrampe
requested changes
Jan 27, 2025
aannleax
force-pushed
the
bug/598-evaluate-expressions-facts
branch
from
26c7b50 to
ffdc345
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that the validate method of Fact was not triggered before, because Facts used the TranslationComponent implementation for
HeadAtom. This PR adds such an implementation forFactitself, which then also calls validate. Furthermore, this PR adds some related error messages to the validation of facts. Finally, constant expressions appearing in facts are now evaluated.Closes #598.