Create Verifiable Credentials #5

sKudryashov · 2022-06-17T17:18:39Z

Implements https://www.notion.so/Create-Integrate-Core-SSI-Rust-Library-Design-9eb9e58093a04a7d84bb476ac0324a7d#a966c7269600446698ecdeea81886afc

src/credential.rs

mkatychev · 2022-07-12T15:57:16Z

core/src/credential.rs

+
+#[derive(Debug, Serialize, Deserialize, Clone)]
+#[serde(bound(deserialize = "'de: 'static"))]
+pub struct VerifiableCredential {


You can use a #[serde(rename_all = "camelCase")] header for the struct whilst keeping explicit fields with their own renames (such as id). Here's an example

mkatychev · 2022-07-12T16:06:15Z

core/src/credential.rs

+}
+
+#[derive(Debug, Serialize, Deserialize, Clone)]
+#[serde(bound(deserialize = "'de: 'static"))]


Looks like we can't suppress this warning yet:
rust-lang/rust#96956

Once that's merged into main we can add #[allow(needless_lifetimes)] here
For now, let's add a comment linking to this post:
https://users.rust-lang.org/t/restrict-generic-type-to-static-lifetime/16915/4

The borrow checker currently isn't smart enough to reason around 'de: 'static bounds.

@LuisOsta @sKudryashov LMK if you have any questions about the two links above

mkatychev · 2022-07-12T16:12:50Z

core/src/credential.rs

+    #[serde(rename = "@id")]
+    id: String,
+    #[serde(rename = "type")]
+    cred_type: String,


if you wanted to keep a field name of type, you could call it r#type: String, it will look weird but this way you can explicitly have the field named self.r#type if you'd like

EDIT: not saying you should, it all depends on how explicit you want the struct to json analogue

Thanks, this is a great trick, since the type word is reserved

I'll keep it as is so far but thank you for introducing it, it is definitely good for the similar situations in the future

mkatychev

LGTM
@sKudryashov we can follow up with suggested changes in a separate PR. The comment section shouldn't hit triple digits 😓

@LuisOsta any concerns about merging as is?

LuisOsta

@mkatychev @sKudryashov There's a couple of issues but apart from them I'm happy to approve this PR

core/Cargo.toml

core/src/credential.rs

core/src/lib.rs

LuisOsta

One minor nit remaining but looks good to me overall

LuisOsta · 2022-07-12T19:24:23Z

core/src/credential.rs

+#[serde(bound(deserialize = "'de: 'static"))]
+pub struct VerifiableCredential {
+    #[serde(flatten)]
+    verifiable_credential:Credential,


This should just be credential

sKudryashov marked this pull request as draft June 17, 2022 17:24

sKudryashov force-pushed the verifiable_credentials branch from 9ef5f3e to 8abb8fa Compare June 17, 2022 17:29

Verifiable credentials creation

158a920

sKudryashov force-pushed the verifiable_credentials branch from 8abb8fa to 158a920 Compare June 17, 2022 20:02

Sergey Kudryashov added 2 commits June 21, 2022 14:35

VC create

9c58768

VC create

6cc07df

sKudryashov force-pushed the verifiable_credentials branch 4 times, most recently from 43ef7b3 to ccd843c Compare June 21, 2022 23:52

Challenge create

faf7ea1

sKudryashov force-pushed the verifiable_credentials branch from ccd843c to faf7ea1 Compare June 22, 2022 00:04

LuisOsta reviewed Jun 22, 2022

View reviewed changes

src/credential.rs Outdated Show resolved Hide resolved

src/credential.rs Outdated Show resolved Hide resolved

Sergey Kudryashov added 2 commits June 23, 2022 09:29

VC creation done

f77c0e6

PR Ready

ec89bd9

sKudryashov marked this pull request as ready for review June 24, 2022 16:21

Sergey Kudryashov added 7 commits June 24, 2022 09:25

Verifiable credentials creation

56b9e81

VC create

dadd363

VC create

42046ab

Challenge create

d461c7b

VC creation done

4a1d781

PR Ready

8d3297f

Fixing conflicts between main and verifiable_credentials

57f2282

sKudryashov requested review from LuisOsta and fkim7 June 24, 2022 16:39

sKudryashov marked this pull request as draft June 24, 2022 16:42

sKudryashov force-pushed the verifiable_credentials branch from 66a2141 to 1c73669 Compare June 24, 2022 16:47

sKudryashov marked this pull request as ready for review June 24, 2022 16:52

PR fix

cc4dcb1

sKudryashov force-pushed the verifiable_credentials branch from 1c73669 to cc4dcb1 Compare June 24, 2022 17:05

Sergey Kudryashov added 3 commits July 6, 2022 16:22

Test fix

fc288e5

VerificationContext Alias implementation

1b0c039

Conflict fix

d8279fb

LuisOsta removed a link to an issue Jul 7, 2022

Implement create_data_integrity_proof for VerifiableCredential in SSI library #17

Closed

LuisOsta linked an issue Jul 7, 2022 that may be closed by this pull request

Implement create_verifiable_credential in SSI library #18

Closed

LuisOsta assigned sKudryashov Jul 7, 2022

Sergey Kudryashov added 4 commits July 8, 2022 12:08

VerificationContext Alias implementation

626c25f

Merging conflicts between main and verifiable_credentials

4a16531

Cargo fix

e90885c

Test passed

02cfbc3

sKudryashov force-pushed the verifiable_credentials branch 2 times, most recently from c5edcc1 to a922440 Compare July 12, 2022 00:31

sKudryashov requested a review from LuisOsta July 12, 2022 00:33

Test fixed

b15ce62

sKudryashov force-pushed the verifiable_credentials branch from c1b8a8a to b15ce62 Compare July 12, 2022 00:35

Sergey Kudryashov added 2 commits July 11, 2022 17:37

Lock file update

707aa7f

Fixing conflict with main

53e22d7

mkatychev reviewed Jul 12, 2022

View reviewed changes

mkatychev approved these changes Jul 12, 2022

View reviewed changes

LuisOsta suggested changes Jul 12, 2022

View reviewed changes

core/Cargo.toml Outdated Show resolved Hide resolved

core/src/credential.rs Outdated Show resolved Hide resolved

core/src/lib.rs Outdated Show resolved Hide resolved

PR fix

f2ba5a7

sKudryashov force-pushed the verifiable_credentials branch from 5c5e4a6 to df2bada Compare July 12, 2022 19:18

LuisOsta approved these changes Jul 12, 2022

View reviewed changes

PR fixes

866f7b3

sKudryashov force-pushed the verifiable_credentials branch from df2bada to 866f7b3 Compare July 12, 2022 19:28

PR fix

50c609b

sKudryashov merged commit a612f33 into main Jul 12, 2022

sKudryashov deleted the verifiable_credentials branch July 12, 2022 19:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create Verifiable Credentials #5

Create Verifiable Credentials #5

sKudryashov commented Jun 17, 2022 •

edited

Loading

mkatychev Jul 12, 2022

mkatychev Jul 12, 2022

mkatychev Jul 12, 2022 •

edited

Loading

sKudryashov Jul 12, 2022

sKudryashov Jul 12, 2022

mkatychev left a comment •

edited

Loading

LuisOsta left a comment

LuisOsta left a comment

LuisOsta Jul 12, 2022

Create Verifiable Credentials #5

Create Verifiable Credentials #5

Conversation

sKudryashov commented Jun 17, 2022 • edited Loading

mkatychev Jul 12, 2022

Choose a reason for hiding this comment

mkatychev Jul 12, 2022

Choose a reason for hiding this comment

mkatychev Jul 12, 2022 • edited Loading

Choose a reason for hiding this comment

sKudryashov Jul 12, 2022

Choose a reason for hiding this comment

sKudryashov Jul 12, 2022

Choose a reason for hiding this comment

mkatychev left a comment • edited Loading

Choose a reason for hiding this comment

LuisOsta left a comment

Choose a reason for hiding this comment

LuisOsta left a comment

Choose a reason for hiding this comment

LuisOsta Jul 12, 2022

Choose a reason for hiding this comment

sKudryashov commented Jun 17, 2022 •

edited

Loading

mkatychev Jul 12, 2022 •

edited

Loading

mkatychev left a comment •

edited

Loading