Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply black formatting #270

Merged
merged 56 commits into from
Dec 17, 2021
Merged

Apply black formatting #270

merged 56 commits into from
Dec 17, 2021

Conversation

joshuaberetta
Copy link
Member

@joshuaberetta joshuaberetta commented Sep 22, 2021

Related issues

closes #268

@joshuaberetta joshuaberetta marked this pull request as ready for review September 22, 2021 22:48
@joshuaberetta joshuaberetta linked an issue Sep 22, 2021 that may be closed by this pull request
len(title)
+ len(rest_of_filename)
- MAXIMUM_FILENAME_LENGTH
len(title) + len(rest_of_filename) - MAXIMUM_FILENAME_LENGTH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 . I think I would keep the way it was. I understand it fits on one line with the parenthesis. But it matched our wish to have operators on the next line.

Copy link
Member Author

@joshuaberetta joshuaberetta Oct 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to keep fighting with black if we do that 😢

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

black is not the almighty ;-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that we cannot then run black across the codebase or as a pre-commit hook if we fight things like this. It would be better not to use black at all then which is still a valid option

Copy link
Contributor

@noliveleger noliveleger Nov 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 The issue is that we cannot then run black across the codebase or as a pre-commit hook

That's exactly my point. The decision should be ours to take. I have to admit that I'm not a big fan of using black a pre-commit hook.

Base automatically changed from 239-drop-python2-support to master October 15, 2021 02:04
@coveralls
Copy link

coveralls commented Oct 26, 2021

Coverage Status

Coverage increased (+0.01%) to 85.725% when pulling c418c5d on 268-black into 611735b on master.

@noliveleger
Copy link
Contributor

@joshuaberetta, please remove the black dependency and open an issue to add it when we have a consensus about it.
We can merge all the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format codebase with Black
3 participants