Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リモートユーザーのノート/フォロー/フォロワー数をリモートサーバーの情報と同じように見えるように #362

Merged
merged 5 commits into from
Aug 31, 2023

Conversation

noridev
Copy link
Collaborator

@noridev noridev commented Aug 29, 2023

What

#359

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

…into follower-and-note-counts-for-remote-users-correct
…into follower-and-note-counts-for-remote-users-correct
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +13.87% 🎉

Comparison is base (b3e7c89) 80.06% compared to head (72639fe) 93.93%.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #362       +/-   ##
============================================
+ Coverage    80.06%   93.93%   +13.87%     
============================================
  Files          185        2      -183     
  Lines        25325      462    -24863     
  Branches       529       59      -470     
============================================
- Hits         20276      434    -19842     
+ Misses        5049       28     -5021     

see 183 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noridev noridev changed the title ノート数とフォロワーとフォロワーの数を連合できるようにする リモートユーザーのノート/フォロー/フォロワー数をリモートサーバーの情報と同じように見えるように Aug 31, 2023
@noridev noridev marked this pull request as ready for review August 31, 2023 09:52
@noridev noridev merged commit fef1ad3 into develop Aug 31, 2023
@noridev noridev deleted the follower-and-note-counts-for-remote-users-correct branch August 31, 2023 09:52
noridev added a commit that referenced this pull request Feb 8, 2025
  - 타사 클라이언트와의 원활한 호환성을 유지하기 위해 변경이 일부 복구되었습니다. (#362)
  - 이 변경으로 팔로워/팔로잉의 공개 범위를 볼 수 없는 사용자는 이제 API에서 `?`이 아닌 `0`을 반환합니다.
@noridev noridev mentioned this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant