-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use prettier #401
chore: use prettier #401
Conversation
Codecov Report
@@ Coverage Diff @@
## main #401 +/- ##
==========================================
+ Coverage 95.53% 95.63% +0.09%
==========================================
Files 18 18
Lines 1186 1213 +27
==========================================
+ Hits 1133 1160 +27
Misses 53 53
Continue to review full report at Codecov.
|
Can we start with a prettier config that approximately matches the current lint style settings? (e.g. single quotes for strings) |
The goal overall to move style rules out of linting and use a base prettier config. So the first question I have: is there a concern you have with moving to prettier's default config? I know it will be a large diff but hoping back commits is quite easy in most editors. Also if we use prettier we will have to forgo at least some style rules even if we attempted to match such as the spacing of object keys, so if the goal is to keep the same style rules we have now then I would say no to prettier and keep them in eslint. |
Sure; I mean at least with the single quote thing:
|
Ah perfect I just want to be sure we are on the same page in terms of moving to prettier is agreed upon. So in the spirit of changes to prettier I think it'll likely be single quotes, 4 units on indent, and 120 line length. I'd have to check if anything else in the docs quickly. I'll also have to double check if we were tabs or spaces quickly since I just set my editors to auto-format to our rules in grumbler-scripts and didn't pay attention. |
Ya for sure, totally happy with prettier, just prefer to do things incrementally when possible. So yeah would be good to stick with single quotes / 4 spaces / etc. for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'm a big fan of using the defaults with the prettier config.
After chatting with the larger team a bit more we have concluded that we would like to pursue the base prettier config and that its probably easiest to just rip the bandaid all at once so we are going to merge this with base config. Of course that means git blaming will typically require you to go back an extra commit but eventually that'd have to be the case to get to the base config for prettier anyways. |
No description provided.