-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added pprof and variable in makefile #1091
Conversation
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@achrefbensaad I've added |
Hi @MdSahil-oss, Sure will do. Yes you can use minikube to test locally. |
@achrefbensaad Thanks for letting me know but what's the procedure to test my changes using minikube ? |
you can use this method. |
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
…unning Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@achrefbensaad I tested |
And confused about how to generate |
Hi @MdSahil-oss , there is no need to create a new dockerfile, you cna modify the ci to build and push two images, one with pprof enabled and one without. Also can you please implement the rest of API's mentioned on the issue. |
@achrefbensaad APIs like: |
Ah ok, Ill test the PR. In the meantime, can you please rebase on top of main to resolve the gosec error. |
@achrefbensaad The flow of generating
|
you can pass the value of |
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@achrefbensaad this PR needs to be reviewed now, Let me know if you find anything to be changed. |
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@achrefbensaad I've updated the PR. |
Lets start by fixing the points above, then we will fix the other parts |
@achrefbensaad I think I have fixed all the points that you mentioned :) |
Hi @MdSahil-oss , yes you have addressed the points I raised earlier, but some new issues were introduced also, please read the reviews above my comment. |
@achrefbensaad I think I have resolved all the reviews you did above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MdSahil-oss Please address the unresolved commits.
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
@achrefbensaad @Ankurk99 Now the value of |
And I kept |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MdSahil-oss Sorry that we didn't follow up on this PR. The changes LGTM, can you please rebase your PR to resolve conflicts. Thank You.
Fixed in #1495 , closing this PR |
Signed-off-by: MdSahil-oss Mohdssahil1@gmail.com
Purpose of PR?:
Fixes #1059
Does this PR introduce a breaking change?
no
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>